RFR: 8300197: Freeze/thaw an interpreter frame using a single copy_to_chunk() call [v2]

[Richard Reingruber]

On Fri, 21 Apr 2023 13:36:55 GMT, Fredrik Bredberg <duke at openjdk.org> wrote:

>> src/hotspot/cpu/ppc/continuationFreezeThaw_ppc.inline.hpp line 510:
>> 
>>> 508:     // we need to set the locals so that the caller of new_stack_frame() can call
>>> 509:     // ContinuationHelper::InterpretedFrame::frame_bottom
>>> 510:     // copy relativized locals from the heap frame
>> 
>> Maybe reduce the comment?
>> 
>>     // we need to copy the locals so that the caller of new_stack_frame() can call
>>     // ContinuationHelper::InterpretedFrame::frame_bottom
>
> I think the comment is good as it is, because it describes just why we need to set the locals this early (and not the rest of the members in the fixed_frame).

So the current version


    // we need to set the locals so that the caller of new_stack_frame() can call
    // ContinuationHelper::InterpretedFrame::frame_bottom
    // copy relativized locals from the heap frame


says that the locals are set and then again that they are copied. I thought that could be combined to what I suggested.
But I'm ok if you still prefer the current version.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1174978882