RFR: JDK-8305387: JDK-8301995 breaks arm 32-bit [v3]

[Matias Saavedra Silva]

On Mon, 24 Apr 2023 18:09:45 GMT, Aleksei Voitylov <avoitylov at openjdk.org> wrote:

>> Provides missing implementation for arm32.
>> 
>> Testing: hotspot/jtreg.
>
> Aleksei Voitylov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address Aleksey review comments

Thanks for taking care of this port! I just have one note about a comment

src/hotspot/cpu/arm/templateTable_arm.cpp line 2665:

> 2663:   __ ldrb(index, Address(cache, in_bytes(ResolvedIndyEntry::result_type_offset())));
> 2664:   // load return address
> 2665:   // Return address is loaded into link register(lr) and not pushed to the stack

This comment is a leftover personal note about how ARM works compared to x86, which I was more familiar with at the time. I think this is intuitive and probably not necessary anymore.

-------------

Marked as reviewed by matsaave (Committer).

PR Review: https://git.openjdk.org/jdk/pull/13596#pullrequestreview-1398682068
PR Review Comment: https://git.openjdk.org/jdk/pull/13596#discussion_r1175710375