RFR: JDK-8305387: JDK-8301995 breaks arm 32-bit [v3]

Aleksei Voitylov avoitylov at openjdk.org
Tue Apr 25 14:02:14 UTC 2023


On Mon, 24 Apr 2023 19:41:06 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Aleksei Voitylov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address Aleksey review comments
>
> src/hotspot/cpu/arm/templateTable_arm.cpp line 2665:
> 
>> 2663:   __ ldrb(index, Address(cache, in_bytes(ResolvedIndyEntry::result_type_offset())));
>> 2664:   // load return address
>> 2665:   // Return address is loaded into link register(lr) and not pushed to the stack
> 
> This comment is a leftover personal note about how ARM works compared to x86, which I was more familiar with at the time. I think this is intuitive and probably not necessary anymore.

Comment is removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13596#discussion_r1176259956


More information about the hotspot-dev mailing list