RFR: JDK-8305387: JDK-8301995 breaks arm 32-bit [v2]

Aleksey Shipilev shade at openjdk.org
Tue Apr 25 09:38:18 UTC 2023


On Mon, 24 Apr 2023 18:39:00 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Well, volatile_barrier is essentially a shell around membar, so here I'm just following the style of the code around.
>
> Honestly, the use of `TemplateTable::volatile_barrier` in `get_cache_and_index_and_bytecode_at_bcp` looks like a fluke/leftover from AArch64 port. `__ membar` is used everywhere else.

It would not stand in the way of integrating this PR, but do consider `__ membar`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13596#discussion_r1176256800


More information about the hotspot-dev mailing list