RFR: JDK-8305387: JDK-8301995 breaks arm 32-bit [v2]

Aleksei Voitylov avoitylov at openjdk.org
Tue Apr 25 14:02:11 UTC 2023


On Tue, 25 Apr 2023 09:31:07 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Honestly, the use of `TemplateTable::volatile_barrier` in `get_cache_and_index_and_bytecode_at_bcp` looks like a fluke/leftover from AArch64 port. `__ membar` is used everywhere else.
>
> It would not stand in the way of integrating this PR, but do consider `__ membar`.

volatile_barrier is widely used in templateTable_arm.cpp instead of plain membar (17 times vs 1 time). Let me file an enhancement to clean this up for the whole file. It does look artificial and specific to TemplateTable only.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13596#discussion_r1176300103


More information about the hotspot-dev mailing list