RFR: 8300197: Freeze/thaw an interpreter frame using a single copy_to_chunk() call [v3]
Fredrik Bredberg
duke at openjdk.org
Wed Apr 26 14:46:23 UTC 2023
On Fri, 21 Apr 2023 16:03:50 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> Your're right @pchilano, it should. But since the line just above is:
>> `const int fsize = heap_frame_bottom - heap_frame_top;`
>> I thought that there was no use in keeping the `assert` at all, so I removed it.
>
> Yes, but it's comparing it with the created stack frame's size so I think it doesn't hurt to keep it. We have an equivalent assert in recurse_freeze_interpreted_frame().
Put back the assert.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1177967812
More information about the hotspot-dev
mailing list