RFR: 8313322: RISC-V: implement MD5 intrinsic [v2]
Antonios Printezis
tonyp at openjdk.org
Tue Aug 1 12:48:52 UTC 2023
On Tue, 1 Aug 2023 06:44:20 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:
>> Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision:
>>
>> changes based on code review feedback
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 1972:
>
>> 1970:
>> 1971: // rotate left with shift bits, 32-bit version
>> 1972: void MacroAssembler::rol32_imm(Register dst, Register src, uint32_t shift, Register tmp) {
>
> You could actually name it `rolw_imm` so that you can easily match it to [rolw](https://github.com/riscv/riscv-bitmanip/blob/6d33919c661a838f6ae89a05650b3ee6aa303440/bitmanip/insns/rolw.adoc#L3) when Zbb is available.
OK.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15090#discussion_r1280576909
More information about the hotspot-dev
mailing list