RFR: JDK-8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer [v3]

[Thomas Stuefe]

On Tue, 8 Aug 2023 18:49:35 GMT, Richard Startin <duke at openjdk.org> wrote:

>> Makes AsyncGetCallTrace more resilient to method unloading.
>
> Richard Startin has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - revert unnecessary whitespace changes
>  - revert yet another unnecessary change
>  - revert unnecessary change

Small nit, otherwise good.

src/hotspot/share/runtime/frame.cpp line 311:

> 309:   }
> 310:   Method* m = (Method*) SafeFetchN((intptr_t*) m_addr, 0);
> 311:   if (m == 0) {

Small nits:
- nullptr instead of 0 
- you can just return m. Its either nullptr or the Method.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15193#pullrequestreview-1568124446
PR Review Comment: https://git.openjdk.org/jdk/pull/15193#discussion_r1287652156