RFR: JDK-8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer [v3]

Richard Startin duke at openjdk.org
Tue Aug 8 21:10:57 UTC 2023


On Tue, 8 Aug 2023 20:23:21 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Richard Startin has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - revert unnecessary whitespace changes
>>  - revert yet another unnecessary change
>>  - revert unnecessary change
>
> src/hotspot/share/runtime/frame.cpp line 311:
> 
>> 309:   }
>> 310:   Method* m = (Method*) SafeFetchN((intptr_t*) m_addr, 0);
>> 311:   if (m == 0) {
> 
> Small nits:
> - nullptr instead of 0 
> - you can just return m. Its either nullptr or the Method.

This didn't compile: `error: cannot convert 'std::nullptr_t' to 'intptr_t' {aka 'long int'}` - I put it back to the literal 0.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15193#discussion_r1287689704


More information about the hotspot-dev mailing list