RFR: 8313905: Checked_cast assert in CDS compare_by_loader [v2]

Dean Long dlong at openjdk.org
Wed Aug 9 20:55:35 UTC 2023


On Wed, 9 Aug 2023 20:22:17 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> To match primitive_equals, we can just use k0 < k1, without the cast to uintptr_t, right?
>
> It compiles and passes the appcds tests so I'm surprised it doesn't need the casts.  I didn't think InstanceKlass pointers could be compared like that directly.

Yes, comparing pointers directly should be fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15208#discussion_r1289164534


More information about the hotspot-dev mailing list