RFR: 8314114: Fix -Wconversion warnings in os code, primarily linux [v3]

[Coleen Phillimore]

On Fri, 11 Aug 2023 17:50:33 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Sorry, I don't like this, nor do I understand what this solves.
>> 
>> `size_t` is, by a deeply ingrained convention, used for memory sizes. It signals that intent clearly to the casual reader of the function declaration. `int` as size for an output buffer is away from conventions and just reads odd. Now this change perforates through all callers up to vmError and other call sites and just makes them all slightly worse, and it is pretty invasive (wrt merging changes to downports).
>
> I just read the other comment as well. Hats off to your pain tolerance, Coleen, I don't aim to belittle your work. I'm just really unhappy with these size_t->int changes. 
> 
> Is there really no better way to solve this? This seems to be an example where solving warnings actually makes the code base worse. Coding against conventions makes the code base brittle (because experienced developers will always use size_t and fall over this).

Ok, I put the size_t parameter back and added the checked cast to the call to print_function_and_library_name.  Propagating size_t lower is going to require another RFE.  Too much fan-out to be part of this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15229#discussion_r1291708245