RFR: 8314114: Fix -Wconversion warnings in os code, primarily linux [v3]

Thomas Stuefe stuefe at openjdk.org
Sat Aug 12 06:15:59 UTC 2023


On Fri, 11 Aug 2023 19:27:40 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I just read the other comment as well. Hats off to your pain tolerance, Coleen, I don't aim to belittle your work. I'm just really unhappy with these size_t->int changes. 
>> 
>> Is there really no better way to solve this? This seems to be an example where solving warnings actually makes the code base worse. Coding against conventions makes the code base brittle (because experienced developers will always use size_t and fall over this).
>
> Ok, I put the size_t parameter back and added the checked cast to the call to print_function_and_library_name.  Propagating size_t lower is going to require another RFE.  Too much fan-out to be part of this.

Thank you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15229#discussion_r1292095769


More information about the hotspot-dev mailing list