RFR: JDK-8314211: Add NativeLibraryUnload event

Martin Doerr mdoerr at openjdk.org
Tue Aug 15 14:26:07 UTC 2023


On Mon, 14 Aug 2023 14:51:50 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> [JDK-8313251](https://bugs.openjdk.org/browse/JDK-8313251) introduced a a NativeLibraryLoad event that provides us more detail about shared lib/dll loads.
> There should be a similar event for unload operations of shared libs.

src/hotspot/os/windows/os_windows.cpp line 1283:

> 1281:     } else {
> 1282:       os::snprintf(buf, sizeof(buf), "Attempt to unload dll failed (error code %d)", (int) errcode);
> 1283:       event.set_errorMessage(buf);

Please move replicated line after if-then-else block. Otherwise, good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15272#discussion_r1294665835


More information about the hotspot-dev mailing list