RFR: JDK-8314211: Add NativeLibraryUnload event [v2]
Matthias Baesken
mbaesken at openjdk.org
Tue Aug 15 15:33:32 UTC 2023
On Tue, 15 Aug 2023 14:23:17 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Simplify os_windows code
>
> src/hotspot/os/windows/os_windows.cpp line 1283:
>
>> 1281: } else {
>> 1282: os::snprintf(buf, sizeof(buf), "Attempt to unload dll failed (error code %d)", (int) errcode);
>> 1283: event.set_errorMessage(buf);
>
> Please move replicated line after if-then-else block. Otherwise, good.
Hi Martin, I adjusted the coding you mentioned .
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15272#discussion_r1294779751
More information about the hotspot-dev
mailing list