RFR: 8313302: Fix formatting errors on Windows [v5]

Stefan Karlsson stefank at openjdk.org
Thu Aug 17 07:45:39 UTC 2023


On Wed, 16 Aug 2023 07:54:28 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove whitespace
>>  - Revert changes of INTPTR_FORMAT, minor improvements
>
> src/hotspot/os/windows/gc/z/zPhysicalMemoryBacking_windows.cpp line 202:
> 
>> 200:     if (!res) {
>> 201:       fatal("Failed to unmap view " PTR_FORMAT " " SIZE_FORMAT "M (%ld)",
>> 202:             static_cast<uintptr_t>(addr), size / M, GetLastError());
> 
> Suggestion:
> 
>             untype(addr), size / M, GetLastError());

This suggestion is still valid.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15063#discussion_r1296809821


More information about the hotspot-dev mailing list