RFR: 8313302: Fix formatting errors on Windows [v5]

[Stefan Karlsson]

On Thu, 17 Aug 2023 05:53:10 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> src/hotspot/os/windows/gc/z/zMapper_windows.cpp line 267:
>> 
>>> 265: 
>>> 266:   if (!res) {
>>> 267:     fatal_error("Failed to split placeholder", static_cast<uintptr_t>(addr), size);
>> 
>> Suggestion:
>> 
>>     fatal_error("Failed to split placeholder", untype(addr), size);
>
> won't these trigger assertions inside fatal error reporting code as Thomas mentioned earlier?

No. See:

inline uintptr_t untype(zaddress_unsafe addr) {
  return static_cast<uintptr_t>(addr);
}


I wonder if Thomas were thinking about the opposite operation, which converts an uintptr_t to a zaddress_unsafe:

inline zaddress_unsafe to_zaddress_unsafe(uintptr_t value) {
  const zaddress_unsafe addr = zaddress_unsafe(value);
  assert_is_valid(addr);
  return addr;
}

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15063#discussion_r1296800443