RFR: 8310596: Utilize existing method frame::interpreter_frame_monitor_size_in_bytes() [v2]

[David Holmes]

On Thu, 24 Aug 2023 08:32:02 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> [small cleanup/enhancement] Adds & updates some code to use `interpreter_frame_monitor_size_in_bytes()` method. I wasn't sure whether we should remove it from PPC & S390 implementation or add it to other archs. For now I have added it but will be happy to revert as PR reviews. 
>> 
>> For s390 `interpreter_frame_interpreterstate_size_in_bytes()` was also cleaned up as it is not being used.
>> 
>> fastdebug build tested on **s390** & **apple m1-pro**.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address @dholmes-ora suggestions

A couple of minor nits to fix but otherwise looks good.

Thanks.

src/hotspot/cpu/aarch64/frame_aarch64.inline.hpp line 317:

> 315: }
> 316: 
> 317: 

Nit: please just restore these files that only have a blank line removed. It will shrink the size of the PR for other reviewers. Thanks.

src/hotspot/share/runtime/frame.hpp line 484:

> 482: 
> 483:   // Additional interface for interpreter frames:
> 484:   static int interpreter_frame_monitor_size_in_bytes();

Please move this, without comment, to after `interpreter_frame_monitor_size` (L372)

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14902#pullrequestreview-1594711846
PR Review Comment: https://git.openjdk.org/jdk/pull/14902#discussion_r1305048917
PR Review Comment: https://git.openjdk.org/jdk/pull/14902#discussion_r1305055534