RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method
Afshin Zafari
azafari at openjdk.org
Fri Aug 25 08:07:09 UTC 2023
On Thu, 24 Aug 2023 16:38:21 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> src/hotspot/share/prims/jvmtiImpl.cpp line 126:
>>
>>> 124: assert(e2 != nullptr, "e2 != nullptr");
>>> 125:
>>> 126: return v->equals(e2);
>>
>> Please rename the `v` parameter to `e1`
>
> And since you're here: Could you change the code style so that it's `GrowableElement* e2` and not `GrowableElement *e2`?
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15418#discussion_r1305332006
More information about the hotspot-dev
mailing list