RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v2]

[David Holmes]

On Wed, 30 Aug 2023 22:58:41 GMT, Jonathan Joo <jjoo at openjdk.org> wrote:

>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address dholmes@ comments

src/hotspot/share/gc/shared/stringdedup/stringDedupThread.hpp line 44:

> 42: 
> 43:   // Perf data for CPU time consumed by the string dedup thread.
> 44:   static PerfVariable* _g1_concurrent_dedup_thread_cpu_time;

This variable seems unused. ??

src/hotspot/share/runtime/vmThread.hpp line 129:

> 127:   static PerfVariable* perf_vm_thread_cpu_time() {
> 128:     return _perf_vm_thread_cpu_time;
> 129:   }

Why do you need an accessor for the cpu-time variable in the VMThread but none of the others?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15082#discussion_r1311127306
PR Review Comment: https://git.openjdk.org/jdk/pull/15082#discussion_r1311126570