RFR: 8319716: RISC-V: Add SHA-2 [v2]

Robbin Ehn rehn at openjdk.org
Mon Dec 4 15:58:45 UTC 2023


On Fri, 1 Dec 2023 19:19:35 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Flag fixes
>>  - Merge branch 'master' into sha256
>>  - Share code
>>  - SHA-2
>
> src/hotspot/cpu/riscv/vm_version_riscv.cpp line 159:
> 
>> 157:   }
>> 158: 
>> 159:   if (UseZvkn) {
> 
> Maybe it's safe to move the code behind `#endif // COMPILER2` at line 291, as it depends on UseRVV.

There is some issues here predating my code:

In

  void generate_compiler_stubs() {                                                                                             

chacha and md5 is generated in the COMPILER2_OR_JVMCI block not the COMPILER2.
So i put sha2 here also which means even if not COMPILER2 is defined it should be defined.

I think all of these should be moved into COMPILER2 block as JVMCI cannot use them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16562#discussion_r1414112339


More information about the hotspot-dev mailing list