RFR: 8318217: RISC-V: C2 VectorizedHashCode [v10]
Yuri Gaevsky
duke at openjdk.org
Fri Dec 8 10:34:57 UTC 2023
On Fri, 8 Dec 2023 08:30:10 GMT, Yuri Gaevsky <duke at openjdk.org> wrote:
>> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1504:
>>
>>> 1502: andi(cnt, cnt, stride-1); // don't forget about tail!
>>> 1503:
>>> 1504: #define DO_ELEMENT_LOAD(reg, idx) \
>>
>> Why not turn `DO_ELEMENT_LOAD` macro into a small function? Say `C2_MacroAssembler::arrays_hashcode_elload`. We can put it after `C2_MacroAssembler::arrays_hashcode_elsize`.
>
> Good idea, will do, thanks.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16629#discussion_r1420247372
More information about the hotspot-dev
mailing list