RFR: 8316197: Make tracing of inline cache available in unified logging [v3]
Yi-Fan Tsai
duke at openjdk.org
Mon Dec 11 07:49:17 UTC 2023
On Mon, 11 Dec 2023 04:46:11 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Enable inlinecache logs in TestTraceICs
>
> test/hotspot/jtreg/compiler/arguments/TestTraceICs.java line 27:
>
>> 25: * @test
>> 26: * @bug 8217447
>> 27: * @summary Test running TraceICs enabled.
>
> The summary is no longer applicable.
>
> But really this test seems some what pointless. It basically checks that `Xlog:inlinecache` is a valid log setting, but doesn't actually check anything interesting.
Updated. TestLogJIT is similar in only enabling the log setting without checking anything.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17026#discussion_r1422043325
More information about the hotspot-dev
mailing list