RFR: 8316197: Make tracing of inline cache available in unified logging [v3]
Vladimir Kozlov
kvn at openjdk.org
Mon Dec 11 16:54:23 UTC 2023
On Mon, 11 Dec 2023 07:47:00 GMT, Yi-Fan Tsai <duke at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/arguments/TestTraceICs.java line 27:
>>
>>> 25: * @test
>>> 26: * @bug 8217447
>>> 27: * @summary Test running TraceICs enabled.
>>
>> The summary is no longer applicable.
>>
>> But really this test seems some what pointless. It basically checks that `Xlog:inlinecache` is a valid log setting, but doesn't actually check anything interesting.
>
> Updated. TestLogJIT is similar in only enabling the log setting without checking anything.
Yes, these tests could check output but it is separate issue. Let keep them and update later.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17026#discussion_r1422799726
More information about the hotspot-dev
mailing list