RFR: 8319716: RISC-V: Add SHA-2 [v4]

Robbin Ehn rehn at openjdk.org
Fri Dec 15 11:16:45 UTC 2023


On Thu, 14 Dec 2023 15:11:02 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> Main author is @luhenry, I only fixed some minor things and tested it.
>> 
>> Such as:
>> test/hotspot/jtreg/compiler/intrinsics/sha/
>> test/jdk/java/security/MessageDigest/
>> test/jdk/jdk/security/
>> tier1
>> 
>> And still running some test.
>
> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Merge branch 'master' into sha256
>  - Materialize constants address once
>  - Removed template
>  - Flag fixes
>  - Merge branch 'master' into sha256
>  - Share code
>  - SHA-2

Hi all, I have address all comments.

The only code change I didn't do was register caching of constants.
This is because I don't have access to sha2 in performance simulator.
Without it 256 and 512 have 'identical' path.
I'll create a jira for that, so I can revisit it once I have access.
I hope that is okay @RealFYang ? (i.e. ship this and do a follow-up)

Also @VladimirKempik the flag issue is not resolved.
For now we use this experimental flag which is inline with the other flags.

Any other things to address, new or that I missed?

(passes compiler/intrinsics/sha/)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16562#issuecomment-1857702779


More information about the hotspot-dev mailing list