RFR: 8319716: RISC-V: Add SHA-2 [v4]

Robbin Ehn rehn at openjdk.org
Sat Dec 16 14:56:43 UTC 2023


On Fri, 15 Dec 2023 14:43:58 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

> > This stubroutine should be inlined via "LibraryCallKit::try_to_inline", meaning there is no call here.
> 
> It is not inlined because it's a stub. If it were to be inlined (which it shouldn't given how big it is), it should be declared in `macroAssembler_riscv.*` with the corresponding C2 Node.

C2 asks if it should inline the method call to: "private void implCompress0(byte[] buf, int ofs)".
As we don't want to call that method we say it is now inlined, by adding a runtime call to a piece of out-of-line code.
For all purposes C2 needs to know this method is now part of this graph.
That is what inlined means in this context, no Java call to that method is generated.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16562#issuecomment-1858836815


More information about the hotspot-dev mailing list