RFR: JDK-8321017: Record in JFR that IEEE rounding mode was corrupted by loading a library [v2]

[Thomas Stuefe]

On Fri, 1 Dec 2023 09:05:22 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> [JDK-8295159](https://bugs.openjdk.org/browse/JDK-8295159) added some IEEE conformance checks and corrections of the floating point environment on Linux and macOS/BSD, and later some UL logging was added too.
>> However the information is not added to the JFR events, and this should be enhanced.
>> The already existing NativeLibraryLoad event can be used for storing the additional information, because the IEEE conformance check and fenv  get/set  is placed in the HS dlopen_helper , where already the NativeLibraryLoad  event objects are created/commited .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust macOS coding

src/hotspot/os/bsd/os_bsd.cpp line 1007:

> 1005:   assert(rtn == 0, "fegetenv must succeed");
> 1006: #endif // IA32
> 1007: 

Its difficult to see what exactly changed on MacOS. Is this restructuring necessary?

src/hotspot/os/bsd/os_bsd.hpp line 73:

> 71:   static void clock_init(void);
> 72: 
> 73:   static void *dlopen_helper(const char *path, int mode, char *ebuf, int ebuflen);

Per-existing, but these helpers should not have been exposed via os::Bsd or os::Linux, they should be filescope static.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16903#discussion_r1429750794
PR Review Comment: https://git.openjdk.org/jdk/pull/16903#discussion_r1429749909