RFR: JDK-8321017: Record in JFR that IEEE rounding mode was corrupted by loading a library [v2]
Matthias Baesken
mbaesken at openjdk.org
Tue Dec 19 09:16:47 UTC 2023
On Mon, 18 Dec 2023 09:16:07 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Adjust macOS coding
>
> src/hotspot/os/bsd/os_bsd.cpp line 1007:
>
>> 1005: assert(rtn == 0, "fegetenv must succeed");
>> 1006: #endif // IA32
>> 1007:
>
> Its difficult to see what exactly changed on MacOS. Is this restructuring necessary?
I wanted to bring the placemenet of the JFR event and also UL logging of Linux (dlopen_helper) and BSD/macOS closer together. With the new structure it is more 'uniform' .
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16903#discussion_r1431122434
More information about the hotspot-dev
mailing list