RFR: 8322179: RISC-V: Implement SHA-1 intrinsic [v2]

Hamlin Li mli at openjdk.org
Tue Dec 19 17:40:51 UTC 2023


On Mon, 18 Dec 2023 16:12:24 GMT, Antonios Printezis <tonyp at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add some comments
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4448:
> 
>> 4446: 
>> 4447:       if (round%2 == 0) {
>> 4448:         __ ld(ws[round/2], Address(buf, 0));
> 
> Instead of incrementing `buf` 8 times, could you just increment the offset (0, 8, 16, etc.) and only increment `buf` once per loop iteration?

Good suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17130#discussion_r1431741088


More information about the hotspot-dev mailing list