RFR: JDK-8321017: Record in JFR that IEEE rounding mode was corrupted by loading a library [v2]
Johannes Bechberger
jbechberger at openjdk.org
Wed Dec 20 13:46:50 UTC 2023
On Fri, 1 Dec 2023 09:05:22 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> [JDK-8295159](https://bugs.openjdk.org/browse/JDK-8295159) added some IEEE conformance checks and corrections of the floating point environment on Linux and macOS/BSD, and later some UL logging was added too.
>> However the information is not added to the JFR events, and this should be enhanced.
>> The already existing NativeLibraryLoad event can be used for storing the additional information, because the IEEE conformance check and fenv get/set is placed in the HS dlopen_helper , where already the NativeLibraryLoad event objects are created/commited .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Adjust macOS coding
src/hotspot/share/jfr/metadata/metadata.xml line 961:
> 959: <Field type="string" name="errorMessage" label="Error Message" description="In case of a load error, error description" />
> 960: <Field type="boolean" name="fpEnvCorrectionAttempt" label="FPU Environment correction" description="In case of IEEE conformance issues we might reset the FP environment" />
> 961: <Field type="boolean" name="fpEnvCorrectionSuccess" label="FPU Environment correction result" description="Stores result in case FP environment correction" />
minor grammatical issue: "Stores the result in the case of an FP environment correction" is better
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16903#discussion_r1432732460
More information about the hotspot-dev
mailing list