RFR: 8301853: C4819 warnings were reported in HotSpot on Windows
Maxim Degtyarev
mdegtyarev at gmail.com
Tue Feb 7 07:25:23 UTC 2023
Isn't it better to replace the multiplication sign with an asterisk
(*) instead of the letter 'x'?
The 'a2xr0 ' looks like a cryptic identifier and not the "multiply a2
to r0". Same for all other changes.
El mar, 7 feb 2023 a las 5:51, Yasumasa Suenaga
(<ysuenaga at openjdk.org>) escribió:
>
> On Mon, 6 Feb 2023 12:33:44 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:
>
> > This is subtask of #12427 .
> >
> > I have seen C4819 warning in stubGenerator_x86_64_poly.cpp and elfFile.hpp in HotSpot on Windows (CP932: Japanese locale)
> >
> >
> > d:\github-forked\jdk\src\hotspot\cpu\x86\stubGenerator_x86_64_poly.cpp(1): error C2220: 次の警告はエラーとして処理されます
> > d:\github-forked\jdk\src\hotspot\cpu\x86\stubGenerator_x86_64_poly.cpp(1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。
>
> We continue to discuss for the encoding of source files in #12436, but I want to merge this to master branch because this PR changes comments only.
>
> -------------
>
> PR: https://git.openjdk.org/jdk/pull/12435
More information about the hotspot-dev
mailing list