RFR: 8301853: C4819 warnings were reported in HotSpot on Windows

David Holmes dholmes at openjdk.org
Wed Feb 8 00:54:42 UTC 2023


On Wed, 8 Feb 2023 00:18:28 GMT, Maxim Degtyarev <mdegtyarev at gmail.com> wrote:

> Isn't it better to replace the multiplication sign with an asterisk (*) instead of the letter 'x'?

No. Asterisk is already used to mean something else

//    * used for poly1305_multiply_scalar
//    x used for poly1305_multiply8_avx512


> The problem here is that the encoding of the file is not properly conveyed.

@magicus That may be the problem with the warning, but I'm more concerned that the special characters won't display properly in typical editing environments. So as a change to hotspot code I am more than happy to see this go in.

-------------

PR: https://git.openjdk.org/jdk/pull/12435


More information about the hotspot-dev mailing list