RFR: 8301853: C4819 warnings were reported in HotSpot on Windows

[David Holmes]

On Mon, 6 Feb 2023 12:33:44 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

> This is subtask of #12427 .
> 
> I have seen C4819 warning in stubGenerator_x86_64_poly.cpp and elfFile.hpp in HotSpot on Windows (CP932: Japanese locale)
> 
> 
> d:\github-forked\jdk\src\hotspot\cpu\x86\stubGenerator_x86_64_poly.cpp(1): error C2220: 次の警告はエラーとして処理されます
> d:\github-forked\jdk\src\hotspot\cpu\x86\stubGenerator_x86_64_poly.cpp(1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。

Visually the difference between × and x is minimal.  Whereas seeing à in place of x is very disruptive. Sure you could argue this is an environment issue and the multiplication symbol should display properly with the right settings, but it is trivial fix, with zero harm, to just replace it with plain x.

-------------

PR: https://git.openjdk.org/jdk/pull/12435