RFR: 8301853: C4819 warnings were reported in HotSpot on Windows
Magnus Ihse Bursie
ihse at openjdk.org
Wed Feb 8 13:17:48 UTC 2023
On Mon, 6 Feb 2023 12:33:44 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:
> This is subtask of #12427 .
>
> I have seen C4819 warning in stubGenerator_x86_64_poly.cpp and elfFile.hpp in HotSpot on Windows (CP932: Japanese locale)
>
>
> d:\github-forked\jdk\src\hotspot\cpu\x86\stubGenerator_x86_64_poly.cpp(1): error C2220: 次の警告はエラーとして処理されます
> d:\github-forked\jdk\src\hotspot\cpu\x86\stubGenerator_x86_64_poly.cpp(1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。
Ok, it's your code, so if you want an `x` instead, go ahead. I fully agree that some special non-ASCII character has no need in the source code, like typographic quotes, and should be replaced by normal ASCII character. I would not have counted this multiplication symbol as unnecessary, but I understand and respect that you think otherwise.
-------------
Marked as reviewed by ihse (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12435
More information about the hotspot-dev
mailing list