RFR: 8294402: Add diagnostic logging to VMProps.checkDockerSupport [v7]

[Mikhailo Seledtsov]

On Thu, 9 Feb 2023 19:08:42 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Re-added conditional logging per review discussion
>
> test/jtreg-ext/requires/VMProps.java line 517:
> 
>> 515:     // Returns comma-separated file names for stdout and stderr.
>> 516:     private String redirectOutputToLogFile(String msg, ProcessBuilder pb, String fileNameBase) {
>> 517:         if (!Boolean.getBoolean("jtreg.log.vmprops")) {
> 
> Why not dump output always? It is printed only if exitcode is not zero anyway and doesn't add noise.
> However not having it in the case of failure require reproducing the bug.

We have to be consistent. Since we agreed in earlier discussion to use property jtreg.log.vmprops as a guard for logging we should also use it for writing into a file. The user who runs the tests can always specify this property in the test execution script.

-------------

PR: https://git.openjdk.org/jdk/pull/12239