RFR: 8294402: Add diagnostic logging to VMProps.checkDockerSupport [v7]

[Mikhailo Seledtsov]

On Thu, 9 Feb 2023 19:32:31 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:

>> test/jtreg-ext/requires/VMProps.java line 517:
>> 
>>> 515:     // Returns comma-separated file names for stdout and stderr.
>>> 516:     private String redirectOutputToLogFile(String msg, ProcessBuilder pb, String fileNameBase) {
>>> 517:         if (!Boolean.getBoolean("jtreg.log.vmprops")) {
>> 
>> Why not dump output always? It is printed only if exitcode is not zero anyway and doesn't add noise.
>> However not having it in the case of failure require reproducing the bug.
>
> We have to be consistent. Since we agreed in earlier discussion to use property jtreg.log.vmprops as a guard for logging we should also use it for writing into a file. The user who runs the tests can always specify this property in the test execution script.

If we take the approach of always logging to vmprops.log then this makes sense. If no objections I will always redirect output into a file.

-------------

PR: https://git.openjdk.org/jdk/pull/12239