RFR: 8294402: Add diagnostic logging to VMProps.checkDockerSupport [v7]

[Mikhailo Seledtsov]

On Thu, 9 Feb 2023 19:23:10 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Re-added conditional logging per review discussion
>
> test/jtreg-ext/requires/VMProps.java line 693:
> 
>> 691:     protected static void log(String msg) {
>> 692:         if (!Boolean.getBoolean("jtreg.log.vmprops")) {
>> 693:             return;
> 
> Why not always log in to the file like vmprops.log? Also, add try/catch into the call() and redirect file to stderr if something is wrong. And redirect if the property is set for passed tests.

I had a discussion with Leonid in person, and I am OK with such approach. To summarize:
  - always log to a file (vmprops.log or similar)
  - this way we always have information to base investigation on if things go wrong
  - conditionally log into stderr to avoid polluting the output and being too verbose
If I do not hear any objections I will proceed with implementation tomorrow.

-------------

PR: https://git.openjdk.org/jdk/pull/12239