RFR: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms [v2]

[Robbin Ehn]

On Fri, 17 Feb 2023 20:59:52 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fixes
>
> src/hotspot/share/code/codeCache.cpp line 1416:
> 
>> 1414: }
>> 1415: 
>> 1416: // Flushes compiled methods dependent on dependee
> 
> nit typo: s/Flushes/Marks/

Fixed, thanks!

> src/hotspot/share/prims/methodHandles.cpp line 959:
> 
>> 957:   {
>> 958:     NoSafepointVerifier nsv;
>> 959:     MutexLocker mu2(CodeCache_lock, Mutex::_no_safepoint_check_flag);
> 
> I missed this naming issue earlier: s/mu2/mu/
> since we only have one Mutex here.

Fixed, thanks!

> src/hotspot/share/prims/methodHandles.cpp line 1336:
> 
>> 1334:     DependencyContext deps = java_lang_invoke_MethodHandleNatives_CallSiteContext::vmdependencies(context());
>> 1335:     deps.remove_and_mark_for_deoptimization_all_dependents(&deopt_scope);
>> 1336:     // This assumed to be an 'atomic' operation by verification.
> 
> nit typo: s/This assumed/This is assumed/

Fixed, thanks!

> src/hotspot/share/prims/methodHandles.hpp line 82:
> 
>> 80:   static void clean_dependency_context(oop call_site);
>> 81: 
>> 82:   static void mark_dependent_nmethods(DeoptimizationScope* deopt_scope, Handle call_site, Handle target);
> 
> Need to update copyright year in this file.

Fixed, thanks!

> src/hotspot/share/runtime/deoptimization.cpp line 109:
> 
>> 107: 
>> 108:   MutexLocker ml(CompiledMethod_lock, Mutex::_no_safepoint_check_flag);
>> 109:   // If there is nothing to deopt _gen is the same as comitted.
> 
> nit typo: s/_gen/_required_gen/

Fixed, thanks!

> src/hotspot/share/runtime/deoptimization.cpp line 143:
> 
>> 141:                  Mutex::_no_safepoint_check_flag);
>> 142:   // A method marked by someone else may have a _gen lower than what we marked with.
>> 143:   // Therefore only store it if it's higher than _gen.
> 
> nit typo: s/_gen/_required_gen/
> in two places

Fixed, thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/12585