RFR: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms [v2]
Robbin Ehn
rehn at openjdk.org
Mon Feb 20 08:54:36 UTC 2023
On Fri, 17 Feb 2023 21:01:47 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review fixes
>
> src/hotspot/share/code/codeCache.hpp line 316:
>
>> 314:
>> 315: // RedefineClasses support
>> 316: // Flushing and deoptimization in case of evolution
>
> nit typo: s/Flushing/Marking/
Fixed with additional name changes, thanks.
> src/hotspot/share/oops/instanceKlass.cpp line 1184:
>
>> 1182: DeoptimizationScope deopt_scope;
>> 1183: {
>> 1184: // Now flush all code that assume the class is not linked.
>
> nit typo: s/assume/assumes/
Fixed, thanks!
> src/hotspot/share/prims/methodHandles.cpp line 1222:
>
>> 1220: MethodHandles::mark_dependent_nmethods(&deopt_scope, call_site, target);
>> 1221: java_lang_invoke_CallSite::set_target(call_site(), target());
>> 1222: // This assumed to be an 'atomic' operation by verification.
>
> nit typo: s/This assumed/This is assumed/
Fixed, thanks!
-------------
PR: https://git.openjdk.org/jdk/pull/12585
More information about the hotspot-dev
mailing list