RFR: JDK-8302989: Add missing INCLUDE_CDS checks

[Matthias Baesken]

On Thu, 23 Feb 2023 21:49:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

> How much space in libjvm does this save? There is a trade-off with code readability when doing this.
> 
> If the aim is to get 100% conditional code then you need to do more. Do plan to do that or just this small tweak?

Hi David,  I would not use the macro with one - liners , I think this is not worth the effort. So no goal to get to 100 %.
It is more like a pragmatic approach (and for the UseSharedSpaces sections it is done already mostly).

>>One question - should (additionally to the UseSharedSpaces code section) the DumpSharedSpaces code sections be guarded as well with INCLUDE_CDS macros 

I wasn't sure about the DumpSharedSpaces  sections, usually the UseSharedSpaces  are guarded with a few exceptions like those addressed in this change.

-------------

PR: https://git.openjdk.org/jdk/pull/12691