RFR: 8299274: Add elements to resolved_references consistently [v2]

[Robbin Ehn]

On Wed, 4 Jan 2023 15:41:22 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I added a resolved_references_at and set_resolved_references_at() functions to use for accesses to the resolved_references array, except for the CDS usages. This has an assert that the element is an oop and oob checks and setting elements use a CAS consistently.
>> These asserts seem useful for finding the bug causing https://bugs.openjdk.org/browse/JDK-8296915.
>> Tested with tiers1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change to objArrayOop to replace_if_null since that is what it's doing.

Thanks!

-------------

Marked as reviewed by rehn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11834