RFR: JDK-8299672: Enhance HeapDump JFR event

[Ralf Schmelter]

On Thu, 5 Jan 2023 14:54:31 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Enhance the JFR Event HeapDump  with the additional interesting fields, compression and overwrite.
> Add some UL logging in case the heap dump writing failed .

Looks good.

test/jdk/jdk/jfr/event/diagnostics/TestHeapDump.java line 68:

> 66:             Events.assertField(e, "onOutOfMemoryError").equal(false);
> 67:             Events.assertField(e, "size").equal(Files.size(path));
> 68:             Events.assertField(e, "compression").equal(-1);

I would use below(1) instead of equals(-1), since it is not specified which value < 1 is used when gzip compression is not enabled. Or you could do the sanitizing when storing the value in the event itself. But in that case I would probably use 0 instead of -1.

-------------

Marked as reviewed by rschmelter (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11864