RFR: JDK-8299672: Enhance HeapDump JFR event [v2]

[Matthias Baesken]

On Mon, 9 Jan 2023 09:39:00 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjust compression check to below in TestHeapDump.java
>
> test/jdk/jdk/jfr/event/diagnostics/TestHeapDump.java line 68:
> 
>> 66:             Events.assertField(e, "onOutOfMemoryError").equal(false);
>> 67:             Events.assertField(e, "size").equal(Files.size(path));
>> 68:             Events.assertField(e, "compression").equal(-1);
> 
> I would use below(1) instead of equals(-1), since it is not specified which value < 1 is used when gzip compression is not enabled. Or you could do the sanitizing when storing the value in the event itself. But in that case I would probably use 0 instead of -1.

Hi Ralf, thanks for the review. 
I adjusted the test as suggested.

-------------

PR: https://git.openjdk.org/jdk/pull/11864