RFR: 8298321: 2 File Leak defect groups in 2 files [v3]
Calvin Cheung
ccheung at openjdk.org
Wed Jan 11 17:44:15 UTC 2023
On Tue, 10 Jan 2023 22:13:40 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> The static analysis tool should be fine about the above change. As I mentioned in the bug report, the warning is regarding the fd is not closed under the conditions HAS_PENDING_EXCEPTION and fd != OS_ERR.
>> I will run rerun the test to be sure.
>
> Do we need to test both debug and release builds? The debug build should be fine due to the assert, but in release build ...
I re-ran tiers 1 and 2 tests using mach5 which tests debug build.
The run with the static analysis tool uses product build.
Both passed.
-------------
PR: https://git.openjdk.org/jdk/pull/11909
More information about the hotspot-dev
mailing list