RFR: 8300002: Performance regression caused by non-inlined hot methods due to post call noop instructions

[Sergey Kuksenko]

On Thu, 12 Jan 2023 06:03:09 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> 8300002: Performance regression caused by non-inlined hot methods due to post call noop instructions
>
> src/hotspot/share/asm/assembler.hpp line 254:
> 
>> 252:     }
>> 253:     void register_nop() {
>> 254:         _assm->count_post_call_nop(_assm->pc() - _nop_start);
> 
> Suggestion:
> 
>       _assm->count_post_call_nop(_assm->pc() - _nop_start);

ok

> src/hotspot/share/asm/codeBuffer.hpp line 211:
> 
>> 209: 
>> 210:   void count_post_call_nop(int size) {
>> 211:       _post_call_nop_size += size;
> 
> Suggestion:
> 
>     _post_call_nop_size += size;

ok

> src/hotspot/share/ci/ciMethod.cpp line 1146:
> 
>> 1144:                        _inline_instructions_size = 0;
>> 1145:                      }
>> 1146:                      );
> 
> Indentation looks weird. I see that you copied it from `ciMethod::instructions_size`, that one should be fixed as well.

ok

-------------

PR: https://git.openjdk.org/jdk/pull/11958