RFR: JDK-8300582: Introduce interface for unaligned memory accesses [v2]

Justin King jcking at openjdk.org
Fri Jan 20 15:17:54 UTC 2023


On Fri, 20 Jan 2023 09:27:48 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/share/utilities/byteswap.hpp line 61:
>> 
>>> 59: #include <type_traits>
>>> 60: 
>>> 61: #if defined(_MSC_VER)
>> 
>> I'd rather see OS specific header files to do all this than pollute what is supposed to be shared code with all this OS specific stuff.
>
>> I'd rather see OS specific header files to do all this than pollute what is supposed to be shared code with all this OS specific stuff.
> 
> Definitely.

Doubling back to this thread, I have now removed all the OS-specific stuff as I mentioned elsewhere. It was unnecessarily pedantic on my part to include it, considering all those platforms use GCC/Clang, MSVC, or XL C/C++.

-------------

PR: https://git.openjdk.org/jdk/pull/12078


More information about the hotspot-dev mailing list