RFR: 8139457: Array bases are aligned at HeapWord granularity [v40]
Roman Kennke
rkennke at openjdk.org
Wed Jul 5 11:09:25 UTC 2023
> See [JDK-8139457](https://bugs.openjdk.org/browse/JDK-8139457) for details.
>
> Basically, when running with -XX:-UseCompressedClassPointers, arrays will have a gap between the length field and the first array element, because array elements will only start at word-aligned offsets. This is not necessary for smaller-than-word elements.
>
> Also, while it is not very important now, it will become very important with Lilliput, which eliminates the Klass field and would always put the length field at offset 8, and leave a gap between offset 12 and 16.
>
> Testing:
> - [x] runtime/FieldLayout/ArrayBaseOffsets.java (x86_64, x86_32, aarch64, arm, riscv, s390)
> - [x] bootcycle (x86_64, x86_32, aarch64, arm, riscv, s390)
> - [x] tier1 (x86_64, x86_32, aarch64, riscv)
> - [x] tier2 (x86_64, aarch64, riscv)
> - [x] tier3 (x86_64, riscv)
Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 60 commits:
- Merge branch 'master' into JDK-8139457
- Address @shipilev's comments
- Build fixes
- Merge branch 'master' into JDK-8139457
- Correctly handle oop array element aligment in 32bit builds; move method from Universe to Array
- Require uncompressed oops to be 8-byte-aligned
- Corresponding XGC fixes
- Merge branch 'master' into JDK-8139457
- Fix calls to removed instanceOopDesc::header_size()
- Add cast
- ... and 50 more: https://git.openjdk.org/jdk/compare/d6578bff...f1dbb859
-------------
Changes: https://git.openjdk.org/jdk/pull/11044/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11044&range=39
Stats: 707 lines in 42 files changed: 486 ins; 120 del; 101 mod
Patch: https://git.openjdk.org/jdk/pull/11044.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/11044/head:pull/11044
PR: https://git.openjdk.org/jdk/pull/11044
More information about the hotspot-dev
mailing list