RFR: JDK-8305962: update jcstress to 0.16 [v2]

Leonid Mesnik lmesnik at openjdk.org
Fri Jul 7 18:13:07 UTC 2023


On Wed, 5 Jul 2023 10:15:26 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixes
>
> test/hotspot/jtreg/applications/jcstress/JcstressRunner.java line 114:
> 
>> 112:         // The "default" preset might take days for some tests
>> 113:         // so use sanity testing by default.
>> 114:         String mode = "sanity";
> 
> `sanity` mode is incorrect for actual testing runs. Should be at least `quick`.

fixed

> test/hotspot/jtreg/applications/jcstress/JcstressRunner.java line 129:
> 
>> 127: 
>> 128:         extraFlags.add("-sc");
>> 129:         extraFlags.add("false");
> 
> Is this to shorten the execution time? I'd recommend `-af GLOBAL` too then, since we are reducing the test matrix for it anyway.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14742#discussion_r1256240981
PR Review Comment: https://git.openjdk.org/jdk/pull/14742#discussion_r1256241706


More information about the hotspot-dev mailing list