RFR: 8311604: Simplify NOCOOPS requested addresses for archived heap objects [v2]

Ioi Lam iklam at openjdk.org
Fri Jul 7 17:12:11 UTC 2023


On Fri, 7 Jul 2023 15:10:20 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @ashu-mehra review; updated source code comments
>
> src/hotspot/share/cds/filemap.cpp line 2072:
> 
>> 2070:     // We can avoid relocation if each region is mapped into the exact same address
>> 2071:     // where it was at dump time.
>> 2072:     return (address)ArchiveHeapWriter::NOCOOPS_REQUESTED_BASE;
> 
> Can you please update the comment above this line as well to remove `each region` as we only have single heap region now.

Thanks for the review. I updated the comment to clarify that this address was hard-coded at dump time, and explained the reason for that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14792#discussion_r1256146742


More information about the hotspot-dev mailing list