RFR: 8311862: RISC-V: small improvements to slli [v2]

Ilya Gavrilin duke at openjdk.org
Wed Jul 12 07:45:15 UTC 2023


On Wed, 12 Jul 2023 06:38:11 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

>> Ilya Gavrilin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo in macroAssembler_riscv.cpp
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 4342:
> 
>> 4340:     _slli_uw(Rd, Rs, shamt);
>> 4341:   } else {
>> 4342:     slli(Rd, Rs, shamt+32);
> 
> Suggestion:
> 
>     slli(Rd, Rs, shamt + 32);

Thank you for your suggestion

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14823#discussion_r1260741827


More information about the hotspot-dev mailing list