RFR: 8311847: Fix -Wconversion for assembler.hpp emit_int8,16 callers [v3]

Andrew Haley aph at openjdk.org
Wed Jul 12 08:56:17 UTC 2023


On Wed, 12 Jul 2023 01:35:26 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review changes to fix -Wconversion warnings that come from assembler_<cpu>.cpp by adding narrow_casts to the emit_int8,16,24, and 32 functions.  And some other fixups with checked_cast.
>> 
>> Ran tier1 on Oracle platforms, and tier1-4 on linux-x64-debug, linux-aarch64-debug, windows-x64-debug.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Unset Wconversion

src/hotspot/share/asm/assembler.hpp line 304:

> 302:    } else {
> 303:      return checked_cast<T>(x);
> 304:    }

Indentation looks wrong?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14822#discussion_r1260841166


More information about the hotspot-dev mailing list